From: Balbir Singh Subject: Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting Date: Tue, 14 Dec 2010 14:55:35 +0530 Message-ID: <20101214092535.GD14178@balbir.in.ibm.com> References: <20101202144129.4357fe00@annuminas.surriel.com> <20101210050344.GR3158@balbir.in.ibm.com> <4D0328CC.1020809@redhat.com> <20101211135727.GU3158@balbir.in.ibm.com> <4D0651BB.9040609@redhat.com> Reply-To: balbir@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Cc: Avi Kivity , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Srivatsa Vaddagiri , Peter Zijlstra , Ingo Molnar , Anthony Liguori , Bharata B Rao To: Rik van Riel Return-path: Content-Disposition: inline In-Reply-To: <4D0651BB.9040609@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org * Rik van Riel [2010-12-13 12:02:51]: > On 12/11/2010 08:57 AM, Balbir Singh wrote: > > >If the vpcu holding the lock runs more and capped, the timeslice > >transfer is a heuristic that will not help. > > That indicates you really need the cap to be per guest, and > not per VCPU. > Yes, I personally think so too, but I suspect there needs to be a larger agreement on the semantics. The VCPU semantics in terms of power apply to each VCPU as opposed to the entire system (per guest). > Having one VCPU spin on a lock (and achieve nothing), because > the other one cannot give up the lock due to hitting its CPU > cap could lead to showstoppingly bad performance. Yes, that seems right! -- Three Cheers, Balbir