From: Wolfgang Denk Date: Sun, 19 Dec 2010 00:19:21 +0100 Subject: [U-Boot] [PATCH] Blackfin: bf518f-ezbrd: don't require SPI logic all the time In-Reply-To: <1291891215-12374-1-git-send-email-vapier@gentoo.org> References: <1291891215-12374-1-git-send-email-vapier@gentoo.org> Message-ID: <20101218231921.9CFEC1557C2@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <1291891215-12374-1-git-send-email-vapier@gentoo.org> you wrote: > Only the first run of boards had a ksz switch on it, so if building for a > newer silicon rev or SPI is disabled, don't bother checking for the ksz. > > Signed-off-by: Mike Frysinger ... > + if (!switch_is_alive) > return -1; > + else > + return 0; > +} Drop the else, and unindent the return 0; > +int board_eth_init(bd_t *bis) > +{ > + if (KSZ_POSSIBLE) > + if (board_ksz_init() == -1) > + return 0; Braces needed for multiline statements. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Computers are not intelligent. They only think they are.