From: Mike Frysinger Date: Sun, 19 Dec 2010 11:33:29 -0500 Subject: [U-Boot] [PATCH] Blackfin: bf525-ucr2: new board port In-Reply-To: <20101219122500.DDB3C14EF8A@gemini.denx.de> References: <1291891702-20707-1-git-send-email-vapier@gentoo.org> <201012182340.27980.vapier@gentoo.org> <20101219122500.DDB3C14EF8A@gemini.denx.de> Message-ID: <201012191133.30875.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday, December 19, 2010 07:25:00 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > > +++ b/board/bf525-ucr2/config.mk > > > > +CONFIG_BFIN_CPU = bf525-0.2 > > > > + > > > > +# Set some default LDR flags based on boot mode. > > > > +LDR_FLAGS += $(LDR_FLAGS-$(CONFIG_BFIN_BOOT_MODE)) > > > > > > Can we not move all this into the board config file, and drop the > > > config.mk ? > > > > i dont know what you're referring to. the cpu needs to be available > > before autoconf.mk is generated, and LDR_FLAGS is a build setting that > > makes more sense to keep in the build .mk. > > I want to get rid of all these board specific config.mk files. > And I don't see a good reason why it would be needed here. Other > boards don;t need any of this either. then where exactly are boards supposed to specify their own custom build settings ? like optimizations that they want to enable on specific files/subdirs ? many Blackfin boards prefer speed over size in the compression code because we arent hurting for space, and most people prefer the faster decompression at runtime. without a board config.mk, that isnt possible. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20101219/de0db56e/attachment.pgp