From: Wolfgang Denk Date: Tue, 21 Dec 2010 09:07:14 +0100 Subject: [U-Boot] [PATCH] Move DECLARE_GLOBAL_DATA_PTR to file scope In-Reply-To: <1292894871-1436-1-git-send-email-john.rigby@linaro.org> References: <1292894871-1436-1-git-send-email-john.rigby@linaro.org> Message-ID: <20101221080714.6FBA5B715C@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear John Rigby, In message <1292894871-1436-1-git-send-email-john.rigby@linaro.org> you wrote: > It can be optimised out by the compiler otherwise resulting > in obscure errors like a board not booting. > > This has been documented in README since 2006 when these were > first fixed up for GCC 4.x. > > Signed-off-by: John Rigby Thanks for the cleanup. Much appreciated. However, this patch appears to miss a few places. I think we should additionally change the following: