From: Wolfgang Denk Date: Tue, 21 Dec 2010 09:07:57 +0100 Subject: [U-Boot] [PATCH] Move DECLARE_GLOBAL_DATA_PTR to file scope In-Reply-To: <4D104687.4030104@free.fr> References: <1292894871-1436-1-git-send-email-john.rigby@linaro.org> <4D104687.4030104@free.fr> Message-ID: <20101221080757.89F85B715C@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Albert ARIBAUD, In message <4D104687.4030104@free.fr> you wrote: > Le 21/12/2010 02:27, John Rigby a =E9crit : > > It can be optimised out by the compiler otherwise resulting > > in obscure errors like a board not booting. > > > > This has been documented in README since 2006 when these were > > first fixed up for GCC 4.x. > > > > Signed-off-by: John Rigby > > --- > > I think this should be considered a bug fix and a potent(ial) help in > getting as many ARM boards working as possible, and so should be put in > v2010.12 if still possible. Indeed. Shall I consider this a formal "Acked-by:" ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The human race is faced with a cruel choice: work or daytime tele- vision.