From: Wolfgang Denk Date: Tue, 21 Dec 2010 13:26:35 +0100 Subject: [U-Boot] [PATCH 2/2] microblaze: Fix bdiinfo pointer In-Reply-To: <1292933384-3032-3-git-send-email-monstr@monstr.eu> References: <1292933384-3032-1-git-send-email-monstr@monstr.eu> <1292933384-3032-2-git-send-email-monstr@monstr.eu> <1292933384-3032-3-git-send-email-monstr@monstr.eu> Message-ID: <20101221122635.17EC4126EB19@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Michal Simek, In message <1292933384-3032-3-git-send-email-monstr@monstr.eu> you wrote: > Patch "Replace CONFIG_SYS_GBL_DATA_SIZE by auto-generated value" > (sha1: 25ddd1fb0a2281b182529afbc8fda5de2dc16d96) > introduce GENERATED_GBL_DATA_SIZE which is sizeof aligned gd_t > (currently 0x40). > Microblaze configs used 0x40(128) because this place also contained > board info structure which lies on the top of ram. > > This patch is fixing this scheme by extending CONFIG_SYS_GBL_DATA_OFFSET > value. Doubled GENERATED_GBL_DATA_SIZE size is enough to store > gd_t and bd_t structures. No, I will not accept this. Please do not make assumptions abouth the size of bd_t compared to GENERATED_GBL_DATA_SIZE. Use the correct size instead, as you can easily get using the sizeof() operator (plus some padding eventually to guarantee alignment, if needed). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I've got to get something inside me. Some coffee or something. And then the world will somehow be better. - Terry Pratchett, _Men at Arms_