From: "J. Bruce Fields" Subject: Re: lock warning in pnfs-all Date: Tue, 21 Dec 2010 13:35:03 -0500 Message-ID: <20101221183503.GB19349@fieldses.org> References: <20101221134556.GA4408@fieldses.org> <176F3D53-A9D3-45D6-85B2-A7478AC3A6F7@netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Benny Halevy , linux-nfs@vger.kernel.org To: Andy Adamson Return-path: Received: from fieldses.org ([174.143.236.118]:36212 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678Ab0LUSfG (ORCPT ); Tue, 21 Dec 2010 13:35:06 -0500 In-Reply-To: <176F3D53-A9D3-45D6-85B2-A7478AC3A6F7@netapp.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Dec 21, 2010 at 01:34:01PM -0500, Andy Adamson wrote: > Hi Bruce > > My latest patch set fixes this - nfs4_set_callback_session was using spin_lock instead of spin_lock_bh. OK, thanks.--b. > > -->Andy > > On Dec 21, 2010, at 8:45 AM, J. Bruce Fields wrote: > > > Tests otherwise complete fine. This may also be in upstream, I haven't > > checked. > > > > --b. > > > > Dec 21 04:17:33 plink2 kernel: ================================= > > Dec 21 04:17:33 plink2 kernel: [ INFO: inconsistent lock state ] > > Dec 21 04:17:33 plink2 kernel: 2.6.37-rc5-pnfs-00434-g89c4ccf #2000 > > Dec 21 04:17:33 plink2 kernel: --------------------------------- > > Dec 21 04:17:33 plink2 kernel: inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage. > > Dec 21 04:17:33 plink2 kernel: 192.168.122.101/7686 [HC0[0]:SC0[0]:HE1:SE1] takes: > > Dec 21 04:17:33 plink2 kernel: (&(&serv->sv_cb_lock)->rlock){+.?...}, at: [] nfs4_set_callback_sessionid+0xb1/0x190 > > Dec 21 04:17:33 plink2 kernel: {IN-SOFTIRQ-W} state was registered at: > > Dec 21 04:17:33 plink2 kernel: [] __lock_acquire+0xba6/0x1c20 > > Dec 21 04:17:33 plink2 kernel: [] lock_acquire+0x92/0x180 > > Dec 21 04:17:33 plink2 kernel: [] _raw_spin_lock+0x3b/0x50 > > Dec 21 04:17:33 plink2 kernel: [] xs_tcp_data_recv+0x650/0xba0 > > Dec 21 04:17:33 plink2 kernel: [] tcp_read_sock+0x116/0x240 > > Dec 21 04:17:33 plink2 kernel: [] xs_tcp_data_ready+0x72/0xb0 > > Dec 21 04:17:33 plink2 kernel: [] tcp_data_queue+0x8cf/0xe80 > > Dec 21 04:17:33 plink2 kernel: [] tcp_rcv_established+0xf6/0x6b0 > > Dec 21 04:17:33 plink2 kernel: [] tcp_v4_do_rcv+0xcd/0x250 > > Dec 21 04:17:33 plink2 kernel: [] tcp_v4_rcv+0x87e/0xae0 > > Dec 21 04:17:33 plink2 kernel: [] ip_local_deliver_finish+0xa9/0x270 > > Dec 21 04:17:33 plink2 kernel: [] ip_local_deliver+0x98/0xa0 > > Dec 21 04:17:33 plink2 kernel: [] ip_rcv_finish+0x128/0x450 > > Dec 21 04:17:33 plink2 kernel: [] ip_rcv+0x205/0x2d0 > > Dec 21 04:17:33 plink2 kernel: [] __netif_receive_skb+0x2e2/0x3d0 > > Dec 21 04:17:33 plink2 kernel: [] netif_receive_skb+0x46/0x50 > > Dec 21 04:17:33 plink2 kernel: [] virtnet_poll+0x535/0x6b0 > > Dec 21 04:17:33 plink2 kernel: [] net_rx_action+0xc5/0x260 > > Dec 21 04:17:33 plink2 kernel: [] __do_softirq+0xe4/0x280 > > Dec 21 04:17:33 plink2 kernel: [] call_softirq+0x1a/0x50 > > Dec 21 04:17:33 plink2 kernel: [] do_softirq+0x8d/0xc0 > > Dec 21 04:17:33 plink2 kernel: [] irq_exit+0x55/0x70 > > Dec 21 04:17:33 plink2 kernel: [] do_IRQ+0x63/0xd0 > > Dec 21 04:17:33 plink2 kernel: [] ret_from_intr+0x0/0xe > > Dec 21 04:17:33 plink2 kernel: [] cpu_idle+0x6b/0x120 > > Dec 21 04:17:33 plink2 kernel: [] rest_init+0xcf/0xe0 > > Dec 21 04:17:33 plink2 kernel: [] start_kernel+0x358/0x363 > > Dec 21 04:17:33 plink2 kernel: [] x86_64_start_reservations+0x131/0x135 > > Dec 21 04:17:33 plink2 kernel: [] x86_64_start_kernel+0xf2/0xf9 > > Dec 21 04:17:33 plink2 kernel: irq event stamp: 187 > > Dec 21 04:17:33 plink2 kernel: hardirqs last enabled at (187): [] kmem_cache_alloc_notrace+0x125/0x1b0 > > Dec 21 04:17:33 plink2 kernel: hardirqs last disabled at (186): [] kmem_cache_alloc_notrace+0x87/0x1b0 > > Dec 21 04:17:33 plink2 kernel: softirqs last enabled at (176): [] rpc_wake_up_next+0x103/0x1e0 > > Dec 21 04:17:33 plink2 kernel: softirqs last disabled at (174): [] _raw_spin_lock_bh+0x16/0x50 > > Dec 21 04:17:33 plink2 kernel: > > Dec 21 04:17:33 plink2 kernel: other info that might help us debug this: > > Dec 21 04:17:33 plink2 kernel: no locks held by 192.168.122.101/7686. > > Dec 21 04:17:33 plink2 kernel: > > Dec 21 04:17:33 plink2 kernel: stack backtrace: > > Dec 21 04:17:33 plink2 kernel: Pid: 7686, comm: 192.168.122.101 Not tainted 2.6.37-rc5-pnfs-00434-g89c4ccf #2000 > > Dec 21 04:17:33 plink2 kernel: Call Trace: > > Dec 21 04:17:33 plink2 kernel: [] print_usage_bug+0x182/0x1d0 > > Dec 21 04:17:33 plink2 kernel: [] mark_lock+0x41b/0x630 > > Dec 21 04:17:33 plink2 kernel: [] __lock_acquire+0xc1c/0x1c20 > > Dec 21 04:17:33 plink2 kernel: [] ? mempool_free_slab+0x17/0x20 > > Dec 21 04:17:33 plink2 kernel: [] ? mempool_free+0x8d/0xa0 > > Dec 21 04:17:33 plink2 kernel: [] ? rpc_free_task+0x50/0x80 > > Dec 21 04:17:33 plink2 kernel: [] lock_acquire+0x92/0x180 > > Dec 21 04:17:33 plink2 kernel: [] ? nfs4_set_callback_sessionid+0xb1/0x190 > > Dec 21 04:17:33 plink2 kernel: [] ? nfs4_set_callback_sessionid+0x6c/0x190 > > Dec 21 04:17:33 plink2 kernel: [] ? get_parent_ip+0x11/0x50 > > Dec 21 04:17:33 plink2 kernel: [] _raw_spin_lock+0x3b/0x50 > > Dec 21 04:17:33 plink2 kernel: [] ? nfs4_set_callback_sessionid+0xb1/0x190 > > Dec 21 04:17:33 plink2 kernel: [] nfs4_set_callback_sessionid+0xb1/0x190 > > Dec 21 04:17:33 plink2 kernel: [] ? nfs4_proc_create_session+0x15f/0x210 > > Dec 21 04:17:33 plink2 kernel: [] nfs41_init_clientid+0x67/0xf0 > > Dec 21 04:17:33 plink2 kernel: [] nfs4_run_state_manager+0x27d/0x5a0 > > Dec 21 04:17:33 plink2 kernel: [] ? nfs4_run_state_manager+0x0/0x5a0 > > Dec 21 04:17:33 plink2 kernel: [] kthread+0x96/0xa0 > > Dec 21 04:17:33 plink2 kernel: [] kernel_thread_helper+0x4/0x10 > > Dec 21 04:17:33 plink2 kernel: [] ? finish_task_switch.clone.3+0x81/0xe0 > > Dec 21 04:17:33 plink2 kernel: [] ? restore_args+0x0/0x30 > > Dec 21 04:17:33 plink2 kernel: [] ? kthread+0x0/0xa0 > > Dec 21 04:17:33 plink2 kernel: [] ? kernel_thread_helper+0x0/0x10 > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html