From: Wolfgang Denk Date: Tue, 21 Dec 2010 22:11:31 +0100 Subject: [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style In-Reply-To: <4D1107D2.7070607@monstr.eu> References: <1292955178-13018-1-git-send-email-monstr@monstr.eu> <20101221185553.8A2E7126EB1A@gemini.denx.de> <4D1107D2.7070607@monstr.eu> Message-ID: <20101221211131.7244C126EB1A@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Michal Simek, In message <4D1107D2.7070607@monstr.eu> you wrote: > > > These changes are to the worse. All. Why do you think this would be > > better? > > It is what intend suggest to do. > intend -npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1 -pcs Please omit the "-pcs" part. It has always been my personal preference, but I've been overruled, and we use plain Lindent these days. > I am OK to remove space between macro name and argument as you suggested > in your other email. > > >> + DEFINE (GENERATED_GBL_DATA_SIZE, > >> + (sizeof (struct global_data) + 15) & ~15); > ^ ^ ^ ^ > > I believe that marked space are OK, or not? Yes. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "If God had wanted us to use the metric system, Jesus would have had 10 apostles."