From: Christoph Hellwig Subject: Re: [PATCH 3/3] compat: copy missing fields in compat_statfs64 to user Date: Mon, 27 Dec 2010 16:36:15 +0100 Message-ID: <20101227153615.GB22676@lst.de> References: <1293381714-5264-1-git-send-email-namhyung@gmail.com> <1293381714-5264-3-git-send-email-namhyung@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig To: Namhyung Kim Return-path: Content-Disposition: inline In-Reply-To: <1293381714-5264-3-git-send-email-namhyung@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Dec 27, 2010 at 01:41:54AM +0900, Namhyung Kim wrote: > f_flags and f_spare fields were not copied to userspace when > compat_sys_[f]statfs64 called. > > Signed-off-by: Namhyung Kim > Cc: Christoph Hellwig > --- > It seems struct compat_statfs lacks the f_flags field in it but I'm not > sure whether it is intended or not. Is it useful if I make a patch for > it too? Looks good. We discussed this a while back before it fell under the table again. Reviewed-by: Christoph Hellwig