Received: from [140.186.70.92] (port=44220 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PYmRO-00049y-Uf for qemu-devel@nongnu.org; Fri, 31 Dec 2010 16:23:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PYmRN-00024J-JH for qemu-devel@nongnu.org; Fri, 31 Dec 2010 16:23:14 -0500 Received: from hall.aurel32.net ([88.191.126.93]:57038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PYmRN-00024F-D4 for qemu-devel@nongnu.org; Fri, 31 Dec 2010 16:23:13 -0500 Date: Fri, 31 Dec 2010 22:23:11 +0100 From: Aurelien Jarno Message-ID: <20101231212311.GH3615@hall.aurel32.net> References: <1293828880-25429-1-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: Aurelien Jarno Subject: [Qemu-devel] Re: [PATCH v2] target-arm: fix UMAAL instruction List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On Fri, Dec 31, 2010 at 09:09:04PM +0000, Peter Maydell wrote: > On 31 December 2010 20:54, Aurelien Jarno wrote: > > UMAAL should use unsigned multiply instead of signed. > > > > This patch fixes this issue by handling UMAAL separately from > > UMULL/UMLAL/SMULL/SMLAL as these instructions are different > > enough. It also explicitly list instructions in case and catch > > nonexistent instruction as illegal. Also fixes a few style issues. > > > > This fixes the issues reported in > > https://bugs.launchpad.net/qemu/+bug/696015 > > > > Cc: Peter Maydell > > Signed-off-by: Aurelien Jarno > > Thanks for the tweaks, looks good to me. > > Reviewed-by: Peter Maydell > Thanks for the review, committed. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net