From: Christoph Egger Subject: Re: [PATCH 04/12] Nested Virtualization: core Date: Fri, 7 Jan 2011 17:31:03 +0100 Message-ID: <201101071731.05094.Christoph.Egger@amd.com> References: <201012201705.06356.Christoph.Egger@amd.com> <201101031658.57065.Christoph.Egger@amd.com> <1A42CE6F5F474C41B63392A5F80372B231D84EA2@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1A42CE6F5F474C41B63392A5F80372B231D84EA2@shsmsx501.ccr.corp.intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Dong, Eddie" Cc: Tim, "xen-devel@lists.xensource.com" , Deegan List-Id: xen-devel@lists.xenproject.org On Thursday 06 January 2011 18:33:56 Dong, Eddie wrote: > >> This is overcomplicated. Static table should serve this much simple > >> and efficient. > > > > The logic to select the right static table will be still needed. I am > > not sure if removing the _xmalloc() call simplifies this part a lot. > > It will be much simple. You don't need the nestedhvm_vcpu_iomap_get/put > api, nor the refcnt. > > The thing more important is policy: If you are in favoring of memory size > or simplicity. If it is for memory size, then you should only allocate 2 > io_bitmap pages for VMX. > > > I appreciate opinions from other people on this. > > Besides, ideally we should implement per guest io bitmap page, by reusing > L1 guest io_bitmap + write protection of the page table. At least for both > Xen & KVM, the io bitmap is not modified at runtime once it is initialized. > The readibility can be improved & the memory page can be saved. We only > need 2 bits per L1 guest. > > But if we want simplicity, I am ok too, however the current patch doesn't > fit for either of the goal. I think, I need to excuse. Now that I did the change in my local tree I have to mention that did not realize that I can remove the put function completely. This in fact is a simplification. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632