From: Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH 01/14] x86/ticketlock: clean up types and accessors Date: Tue, 11 Jan 2011 12:21:00 -0500 Message-ID: <20110111172100.GA14017@dumpdata.com> References: <92d21a90d4e27db4b46dbacd58ef67719acd0185.1289940821.git.jeremy.fitzhardinge@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <92d21a90d4e27db4b46dbacd58ef67719acd0185.1289940821.git.jeremy.fitzhardinge@citrix.com> Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: Peter Zijlstra , Xen-devel , Mathieu Desnoyers , Nick Piggin , Srivatsa Vaddagiri , Linux Kernel Mailing List , Jan Beulich , Eric Dumazet , Jeremy Fitzhardinge , Avi Kivity , "H. Peter Anvin" , =?iso-8859-1?Q?Am=E9rico?= Wang , Linux Virtualization List-Id: xen-devel@lists.xenproject.org > static inline int __ticket_spin_is_locked(arch_spinlock_t *lock) > { > - int tmp = ACCESS_ONCE(lock->slock); > + struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets); > > - return !!(((tmp >> TICKET_SHIFT) ^ tmp) & ((1 << TICKET_SHIFT) - 1)); > + return !!(tmp.tail ^ tmp.head); Does it make sense to mask it here it here with TICKET_MASK as it was done before?