From: Al Viro Subject: Re: vfs-scale, d_revalidate from nfsd Date: Fri, 14 Jan 2011 03:20:53 +0000 Message-ID: <20110114032052.GV19804@ZenIV.linux.org.uk> References: <8855.1294927436@jrobl> <20110114030325.GU19804@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "J. R. Okajima" , linux-fsdevel , linux-kernel@vger.kernel.org To: Nick Piggin Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:56944 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752304Ab1ANDU5 (ORCPT ); Thu, 13 Jan 2011 22:20:57 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jan 14, 2011 at 02:12:35PM +1100, Nick Piggin wrote: > The main idea here would be to just pass in a flags parameter rather > thank poking in nd to get the rcu-walk status. That would solve this > problem and also avoid nd for most filesystems that don't care about > it. Start with nd->flags getting passed explicitly, and be ready to see * call on the final stage of open split away and folded with ->lookup() and ->open()/->creat() * the rest of callers to lose nd completely. That's what's going to happen in the next cycle. BTW, why on the earth do you have that: static int xattr_hide_revalidate(struct dentry *dentry, struct nameidata *nd) { if (nd->flags & LOOKUP_RCU) return -ECHILD; return -EPERM; } when the sole intent of that sucker is to have dentry of /.xattr (pinned in dcache and hashed all along) rejected on lookups from root? IOW, WTF bother with -ECHILD here at all?