From: Al Viro Subject: Re: vfs-scale, d_revalidate from nfsd Date: Fri, 14 Jan 2011 03:22:24 +0000 Message-ID: <20110114032224.GW19804@ZenIV.linux.org.uk> References: <8855.1294927436@jrobl> <20110114030325.GU19804@ZenIV.linux.org.uk> <20110114032052.GV19804@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "J. R. Okajima" , linux-fsdevel , linux-kernel@vger.kernel.org To: Nick Piggin Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:56952 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815Ab1ANDWZ (ORCPT ); Thu, 13 Jan 2011 22:22:25 -0500 Content-Disposition: inline In-Reply-To: <20110114032052.GV19804@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > BTW, why on the earth do you have that: > static int xattr_hide_revalidate(struct dentry *dentry, struct nameidata *nd) > { > if (nd->flags & LOOKUP_RCU) > return -ECHILD; > return -EPERM; > } > when the sole intent of that sucker is to have dentry of /.xattr (pinned > in dcache and hashed all along) rejected on lookups from root? IOW, WTF > bother with -ECHILD here at all? PS: that's fs/reiserfs/xattr.c