From: Srivatsa Vaddagiri Subject: Re: [PATCH 13/14] x86/ticketlock: add slowpath logic Date: Mon, 17 Jan 2011 20:52:22 +0530 Message-ID: <20110117152222.GA19233@linux.vnet.ibm.com> References: <97ed99ae9160bdb6477284b333bd6708fb7a19cb.1289940821.git.jeremy.fitzhardinge@citrix.com> Reply-To: vatsa@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <97ed99ae9160bdb6477284b333bd6708fb7a19cb.1289940821.git.jeremy.fitzhardinge@citrix.com> Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: Peter Zijlstra , Linux Kernel Mailing List , Nick Piggin , Mathieu Desnoyers , =?iso-8859-1?Q?Am=E9rico?= Wang , Eric Dumazet , Jan Beulich , Avi Kivity , Xen-devel , "H. Peter Anvin" , Linux Virtualization , Jeremy Fitzhardinge , suzuki@in.ibm.com List-Id: xen-devel@lists.xenproject.org On Tue, Nov 16, 2010 at 01:08:44PM -0800, Jeremy Fitzhardinge wrote: > From: Jeremy Fitzhardinge > > Maintain a flag in both LSBs of the ticket lock which indicates whether > anyone is in the lock slowpath and may need kicking when the current > holder unlocks. The flags are set when the first locker enters > the slowpath, and cleared when unlocking to an empty queue. > > In the specific implementation of lock_spinning(), make sure to set > the slowpath flags on the lock just before blocking. We must do > this before the last-chance pickup test to prevent a deadlock > with the unlocker: > > Unlocker Locker > test for lock pickup > -> fail > test slowpath + unlock > -> false > set slowpath flags > block > > Whereas this works in any ordering: > > Unlocker Locker > set slowpath flags > test for lock pickup > -> fail > block > test slowpath + unlock > -> true, kick I think this is still racy .. Unlocker Locker test slowpath -> false set slowpath flag test for lock pickup -> fail block unlock unlock needs to happen first before testing slowpath? I have made that change for my KVM guest and it seems to be working well with that change .. Will cleanup and post my patches shortly - vatsa