From: Srivatsa Vaddagiri Subject: Re: [PATCH 13/14] x86/ticketlock: add slowpath logic Date: Thu, 20 Jan 2011 00:09:14 +0530 Message-ID: <20110119183914.GB7235@linux.vnet.ibm.com> References: <97ed99ae9160bdb6477284b333bd6708fb7a19cb.1289940821.git.jeremy.fitzhardinge@citrix.com> <20110117152222.GA19233@linux.vnet.ibm.com> <4D372DEA.1060004@goop.org> Reply-To: vatsa@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4D372DEA.1060004@goop.org> Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: Peter Zijlstra , Linux Kernel Mailing List , Nick Piggin , Mathieu Desnoyers , =?iso-8859-1?Q?Am=E9rico?= Wang , Eric Dumazet , Jan Beulich , Avi Kivity , Xen-devel , "H. Peter Anvin" , Linux Virtualization , Jeremy Fitzhardinge , suzuki@in.ibm.com List-Id: xen-devel@lists.xenproject.org On Wed, Jan 19, 2011 at 10:31:06AM -0800, Jeremy Fitzhardinge wrote: > I think you're probably right; when I last tested this code, it was > hanging in at about the rate this kind of race would cause. And in my > previous analysis of similar schemes (the current pv spinlock code), it > was always correct to do the "slowpath" test after doing do the unlock. > > *But* I haven't yet had the chance to specifically go through and > analyse your patch in detail to make sure there's nothing else going on, > so take this as provisional. > > How much testing have you given it? I have tested quite extensively with booting a 16-vcpu guest (on a 16-pcpu host) and running kernel compine (with 32-threads). Without this patch, I had difficulty booting/shutting-down successfully (it would hang mid-way). - vatsa