From: Wolfgang Denk Date: Mon, 24 Jan 2011 19:58:12 +0100 Subject: [U-Boot] [PATCH V5 1/4] arm: Tegra2: Add basic NVIDIA Tegra2 SoC support In-Reply-To: <1295651217-32421-2-git-send-email-twarren@nvidia.com> References: <1295651217-32421-1-git-send-email-twarren@nvidia.com> <1295651217-32421-2-git-send-email-twarren@nvidia.com> Message-ID: <20110124185812.5CB18B187@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Tom Warren, In message <1295651217-32421-2-git-send-email-twarren@nvidia.com> you wrote: > Signed-off-by: Tom Warren >... ... > +/* Clock/Reset Controller (CLK_RST_CONTROLLER_) regs */ > +typedef volatile struct clk_rst_ctlr { ... > +/* APB MISC Pin Mux and Tristate (APB_MISC_PP_) registers */ > +typedef volatile struct pinmux_tri_ctlr { ... > +/* Power Management Controller (APBDEV_PMC_) registers */ > +typedef volatile struct pmc_ctlr { ... > +#ifndef __ASSEMBLY__ > +typedef volatile struct timerus { > + unsigned int cntr_1us; > +} timerus_t; ... > +/* UART registers */ > +typedef volatile struct uart_ctlr { Please drop the "typedef" and the "volatile" from all these (and all other, similar) declarations. See linux/Documentation/CodingStyle: It's a _mistake_ to use typedef for structures and pointers. See Documentation/volatile-considered-harmful.txt Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I am a computer. I am dumber than any human and smarter than any ad- ministrator.