From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] fix pgd_lock deadlock
Date: Wed, 16 Feb 2011 21:15:24 +0100
Message-ID: <20110216201524.GA7839@elte.hu>
References: <20110215195450.GO5935@random.random>
 <alpine.LFD.2.00.1102152102530.26192@localhost6.localdomain6>
 <alpine.LFD.2.00.1102152125180.26192@localhost6.localdomain6>
 <20110215225234.GP5935@random.random>
 <alpine.LFD.2.00.1102160002300.26192@localhost6.localdomain6>
 <20110215231733.GR5935@random.random>
 <1297850294.2413.30.camel@twins>
 <20110216101521.GU5935@random.random>
 <20110216102801.GA23082@elte.hu>
 <20110216144947.GA5935@random.random>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20110216144947.GA5935@random.random>
Sender: linux-kernel-owner@vger.kernel.org
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, Jeremy Fitzhardinge <jeremy@goop.org>, "H. Peter Anvin" <hpa@zytor.com>, the arch/x86 maintainers <x86@kernel.org>, "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <JBeulich@novell.com>, Larry Woodman <lwoodman@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, Andi Kleen <ak@suse.de>, Johannes Weiner <jweiner@redhat.com>, Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>
List-Id: xen-devel@lists.xenproject.org


* Andrea Arcangeli <aarcange@redhat.com> wrote:

> Ok sorry, but whenever I'm asked if I tested my patch with lockdep, I think if it 
> was tested for other bugs, not to remove debug code overlapping with some lockdep 
> feature.

ah, ok. The thing is, if it was only a single VM_BUG_ON() then it wouldnt be a big 
deal. Seven seems excessive - especially since we have that very check via lockdep.

Thanks for removing them!

	Ingo