From: Li Dongyang Subject: Re: [PATCH]do not allow multiple xenconsole connect to the same pty Date: Thu, 17 Feb 2011 11:32:43 +0800 Message-ID: <201102171132.43135.lidongyang@novell.com> References: <201102151207.38331.lidongyang@novell.com> <19802.54932.293842.532179@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19802.54932.293842.532179@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org On Wednesday, February 16, 2011 03:40:04 AM Ian Jackson wrote: > Li Dongyang writes ("[Xen-devel] [PATCH]do not allow multiple xenconsole connect to the same pty"): > > allowing multiple xenconsole connect to the same pty is just insane, > > prevent this by acquiring a write flock on the pty fd once we opened it. > > I don't think that flocking a pty is likely to be very portable. Thanks for reviewing, and what do you mean by 'not likely to be very portable'? flock(2) is not POSIX, but fcntl(3p) is POSIX, maybe I missed somthing? Li Dongyang > > I guess what happens at the moment if you do this is that input is > interleaved (fine) but output is distributed randomly amongst the > available clients ? > > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel