From: Christoph Egger Subject: [PATCH] libxl regression: don't require vncpasswd when empty Date: Fri, 18 Feb 2011 17:38:07 +0100 Message-ID: <201102181738.08164.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_wBqXNDUDWQAy6BZ" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --Boundary-00=_wBqXNDUDWQAy6BZ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, this is a resending as a reminder! Attached patch fixes a regression introduced in c/s 22866:ed9ef3b07d2a: Don't require a NULL-byte password when the guest config file has the entry vncpasswd='' Signed-off-by: Christoph Egger -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --Boundary-00=_wBqXNDUDWQAy6BZ Content-Type: text/x-diff; charset="iso 8859-15"; name="xen_libxl_vncpasswd.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen_libxl_vncpasswd.diff" Content-Description: xen_libxl_vncpasswd.diff diff -r 12de39a2c580 tools/libxl/libxl_dm.c --- a/tools/libxl/libxl_dm.c Thu Feb 10 15:18:51 2011 +0100 +++ b/tools/libxl/libxl_dm.c Fri Feb 11 11:03:59 2011 +0100 @@ -74,7 +74,7 @@ static char ** libxl_build_device_model_ } else { vncarg = "127.0.0.1:0"; } - if (info->vncpasswd) + if (info->vncpasswd && (info->vncpasswd[0] != '\0')) vncarg = libxl__sprintf(gc, "%s,password", vncarg); flexarray_append(dm_args, "-vnc"); flexarray_append(dm_args, vncarg); --Boundary-00=_wBqXNDUDWQAy6BZ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_wBqXNDUDWQAy6BZ--