From: Kenneth Graunke Subject: Re: [PATCH] intel: Add AUB file dump support Date: Tue, 22 Feb 2011 18:18:55 -0800 Message-ID: <201102221818.55470.kenneth@whitecape.org> References: <1297836461-31543-1-git-send-email-zhenyuw@linux.intel.com> <87wrksug7x.fsf@pollan.anholt.net> <20110223014957.GR22867@zhen-devel.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from hapkido.dreamhost.com (hapkido.dreamhost.com [66.33.216.122]) by gabe.freedesktop.org (Postfix) with ESMTP id 6515C9E76F for ; Tue, 22 Feb 2011 18:18:56 -0800 (PST) Received: from homiemail-a4.g.dreamhost.com (mailbigip.dreamhost.com [208.97.132.5]) by hapkido.dreamhost.com (Postfix) with ESMTP id 9520F179F7B for ; Tue, 22 Feb 2011 18:18:55 -0800 (PST) Received: from homiemail-a4.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a4.g.dreamhost.com (Postfix) with ESMTP id 1669951C06C for ; Tue, 22 Feb 2011 18:18:54 -0800 (PST) Received: from ratchet.localnet (pool-173-50-155-26.ptldor.fios.verizon.net [173.50.155.26]) (Authenticated sender: kenneth@whitecape.org) by homiemail-a4.g.dreamhost.com (Postfix) with ESMTPA id F2DAF51C062 for ; Tue, 22 Feb 2011 18:18:53 -0800 (PST) In-Reply-To: <20110223014957.GR22867@zhen-devel.sh.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tuesday, February 22, 2011 05:49:57 PM Zhenyu Wang wrote: [snip] > > We also can't commit code to Mesa that just writes into some arbitrary > > file based on an environment variable -- keep in mind that our Mesa > > driver is loaded from the X Server which is running as root. > > yeah, I wasn't aware of this, any comment for how to dump the file? We could simply not commit this patch to master, but keep it in a branch and apply it when we need AUB file dumping support. Alternatively, perhaps we could commit everything, but change patch 1/3 to: #if 0 { "aub", DEBUG_AUB }, #endif This makes it ridiculously easy for us to enable INTEL_DEBUG=aub, but doesn't ship the potential security exploit. Also, since a .c file would have to be changed, it's unlikely a distributor would accidentally enable it. Thoughts?