Received: from [140.186.70.92] (port=37546 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pwq24-0004TY-Td for qemu-devel@nongnu.org; Tue, 08 Mar 2011 01:04:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pwq23-0004Eo-Qo for qemu-devel@nongnu.org; Tue, 08 Mar 2011 01:04:33 -0500 Received: from [88.191.126.93] (port=46799 helo=hall.aurel32.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pwq23-0004EK-L0 for qemu-devel@nongnu.org; Tue, 08 Mar 2011 01:04:31 -0500 Date: Tue, 8 Mar 2011 07:04:29 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH v5 10/10] softfloat: Use [u]int_fast64_t consistently Message-ID: <20110308060429.GF10422@hall.aurel32.net> References: <1299458053-69428-3-git-send-email-andreas.faerber@web.de> <1299458053-69428-4-git-send-email-andreas.faerber@web.de> <1299458053-69428-5-git-send-email-andreas.faerber@web.de> <1299458053-69428-6-git-send-email-andreas.faerber@web.de> <1299458053-69428-7-git-send-email-andreas.faerber@web.de> <1299458053-69428-8-git-send-email-andreas.faerber@web.de> <1299458053-69428-9-git-send-email-andreas.faerber@web.de> <1299458053-69428-10-git-send-email-andreas.faerber@web.de> <20110307095635.GG10503@volta.aurel32.net> <41C23B0C-8F0B-4168-90BD-20CF88F9BFF9@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <41C23B0C-8F0B-4168-90BD-20CF88F9BFF9@web.de> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-15?Q?F=E4rber?= Cc: qemu-devel@nongnu.org On Tue, Mar 08, 2011 at 12:10:50AM +0100, Andreas Färber wrote: > Am 07.03.2011 um 10:56 schrieb Aurelien Jarno: > > >On Mon, Mar 07, 2011 at 01:34:13AM +0100, Andreas Färber wrote: > >>v5: > >>* Initial. > >> > >>Signed-off-by: Andreas Färber > >>--- > >>fpu/softfloat-native.c | 26 +++++++++++++------------- > >>fpu/softfloat-native.h | 28 ++++++++++++++-------------- > >>fpu/softfloat.c | 4 ++-- > >>3 files changed, 29 insertions(+), 29 deletions(-) > > >>diff --git a/fpu/softfloat-native.h b/fpu/softfloat-native.h > >>index 6cf5dc3..b198f48 100644 > >>--- a/fpu/softfloat-native.h > >>+++ b/fpu/softfloat-native.h > > >>@@ -392,8 +392,8 @@ INLINE float64 float64_scalbn(float64 a, int n) > >>*----------------------------------------------------------------------------*/ > >>int_fast32_t floatx80_to_int32( floatx80 STATUS_PARAM ); > >>int_fast32_t floatx80_to_int32_round_to_zero( floatx80 > >>STATUS_PARAM ); > >>-int64_t floatx80_to_int64( floatx80 STATUS_PARAM); > >>-int64_t floatx80_to_int64_round_to_zero( floatx80 STATUS_PARAM); > >>+int64_fast_t floatx80_to_int64( floatx80 STATUS_PARAM); > >>+int64_fast_t floatx80_to_int64_round_to_zero( floatx80 > >>STATUS_PARAM); > > > >This type doesn't exist, so the code doesn't even compile... > > I did compile-tested these, so apparently my host or targets do not > use softfloat-native... It was late so I can't rule out other > mistakes there. softfloat-native is used on i386 and x86_64 targets, which are enabled by default when running ./configure. > Would you prefer to treat softfloat-native as a separate API and not > touch it in this series? > In my opinion, if we do such change, we should do them in both softfloat and softfloat-native. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net