From: Samuel Thibault Subject: Re: [PATCH 0/12] VTPM mini-os: TPM device drivers for mini-os Date: Sat, 12 Mar 2011 01:37:05 +0100 Message-ID: <20110312003705.GG4922@const.famille.thibault.fr> References: <4D7AA743.5030703@jhuapl.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Resent-Message-ID: <20110312013955.GL4922@const.famille.thibault.fr> Resent-To: xen-devel@lists.xensource.com Content-Disposition: inline In-Reply-To: <4D7AA743.5030703@jhuapl.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Matthew Fioravante Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Matthew Fioravante, le Fri 11 Mar 2011 17:50:43 -0500, a =E9crit : > This patch adds 3 new drivers to mini-os >=20 > tpmfront: Paravirtualized tpm driver that can speak to mini-os tpmback=20 > and linux tpmbk > tpmback: Paravirtualized tpm backend driver that can speak to mini-os=20 > tpmfront and linux tpm_xenu > tpm_tis: Hardware tpm driver. Should work with any TPM device compliant= =20 > with the 1.2 spec. Requires io memory passthrough. >=20 > Signed off by: Matthew Fioravante I don't have the time to review the driver code in details, but the overall shape and interaction with the rest of mini-os looks good to me. > @@ -177,6 +179,7 @@ > } tap; > struct { > struct blkfront_dev *dev; > + off_t offset; > } blk; > struct { > struct kbdfront_dev *dev; This seems like an unrelated change, right? Samuel