From: Samuel Thibault Subject: Re: [PATCH 4/12] VTPM mini-os: Mini-os machine specific headers Date: Mon, 14 Mar 2011 18:35:57 +0100 Message-ID: <20110314173557.GA4370@const.famille.thibault.fr> References: <4D7AA5B1.8060603@jhuapl.edu> <20110312003112.GE4922@const.famille.thibault.fr> <4D7E4A20.1050002@jhuapl.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Resent-Message-ID: <20110314175227.GD4370@const.famille.thibault.fr> Resent-To: xen-devel@lists.xensource.com Content-Disposition: inline In-Reply-To: <4D7E4A20.1050002@jhuapl.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Matthew Fioravante Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Matthew Fioravante, le Mon 14 Mar 2011 13:02:24 -0400, a =E9crit : > Which part? The check for gcc version >=3D 4.3 or the #defines for bswa= p_XX? >=20 > I think its correct The 64bit #define. If it's really meant to be using __builtin_bswap32 in= stead of __builtin_bswap64, a comment should say why :) > On 03/11/2011 07:31 PM, Samuel Thibault wrote: > >Matthew Fioravante, le Fri 11 Mar 2011 17:44:01 -0500, a =E9crit : > >>+/* Use gcc optimized versions if they exist */ > >>+#if __GNUC__> 4 || (__GNUC__ =3D=3D 4&& __GNUC_MINOR__>=3D 3) > >>+#define bswap_32(v) __builtin_bswap32(v) > >>+#define bswap_64(v) __builtin_bswap32(v) > >Typo here, right? Samuel