From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] watchdog, SP5100: Check if firmware has set correct value in tcobase. Date: Wed, 16 Mar 2011 20:00:35 -0400 Message-ID: <20110317000035.GA3613@dumpdata.com> References: <20110311222129.GA3168@dumpdata.com> <4D80F992.10603@kernel.org> <4D812180.5030102@kernel.org> <4D812919.30706@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4D812919.30706@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Yinghai Lu Cc: Mike Waychison , Wim Van Sebroeck , Stefano Stabellini , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , Jeremy Fitzhardinge , "xen-devel@lists.xensource.com" , linux-watchdog@vger.kernel.org, Priyanka Gupta List-Id: xen-devel@lists.xenproject.org On Wed, Mar 16, 2011 at 02:18:17PM -0700, Yinghai Lu wrote: > > > Stefano found SP5100 TCO watchdog driver using wrong address. > > [ 9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01 > [ 9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 reserved=1 > > and e820 said that range is RAM. > > We should check if we can use that reading out. BIOS could just program wrong address there. > > -v2: Mike pointed out one path need one release. > > Reported-by: Stefano Stabellini > Signed-off-by:Yinghai Lu > Acked-by: Mike Waychison Tested-by: Konrad Rzeszutek Wilk Stefano, this fixes my bootup issues with your: xen: set max_pfn_mapped to the last pfn mapped patch. Will try the full patchset tomorrow.