From: Jesse Barnes Subject: Re: [PATCH 2/8] drm/i915: remove LBB config save/restore Date: Mon, 21 Mar 2011 10:36:01 -0700 Message-ID: <20110321103601.5312ef35@jbarnes-desktop> References: <1300699639-23996-1-git-send-email-zhenyuw@linux.intel.com> <1300699639-23996-3-git-send-email-zhenyuw@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com [66.147.249.253]) by gabe.freedesktop.org (Postfix) with SMTP id E23619E9E1 for ; Mon, 21 Mar 2011 10:36:04 -0700 (PDT) In-Reply-To: <1300699639-23996-3-git-send-email-zhenyuw@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zhenyu Wang Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 21 Mar 2011 17:27:13 +0800 Zhenyu Wang wrote: > we don't use it anywhere. > > Signed-off-by: Zhenyu Wang > --- > drivers/gpu/drm/i915/i915_suspend.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c > index 0521ecf..422981b 100644 > --- a/drivers/gpu/drm/i915/i915_suspend.c > +++ b/drivers/gpu/drm/i915/i915_suspend.c > @@ -795,8 +795,6 @@ int i915_save_state(struct drm_device *dev) > struct drm_i915_private *dev_priv = dev->dev_private; > int i; > > - pci_read_config_byte(dev->pdev, LBB, &dev_priv->saveLBB); > - > /* Hardware status page */ > dev_priv->saveHWS = I915_READ(HWS_PGA); > > @@ -844,8 +842,6 @@ int i915_restore_state(struct drm_device *dev) > struct drm_i915_private *dev_priv = dev->dev_private; > int i; > > - pci_write_config_byte(dev->pdev, LBB, dev_priv->saveLBB); > - > /* Hardware status page */ > I915_WRITE(HWS_PGA, dev_priv->saveHWS); This may affect older platforms and prevent backlight save/restore? At least I think that's why we added it in the first place... -- Jesse Barnes, Intel Open Source Technology Center