From: Jesse Barnes Subject: Re: [PATCH 4/8] drm/i915: remove CACHE_MODE_0 save/restore Date: Mon, 21 Mar 2011 10:40:51 -0700 Message-ID: <20110321104051.78a89723@jbarnes-desktop> References: <1300699639-23996-1-git-send-email-zhenyuw@linux.intel.com> <1300699639-23996-5-git-send-email-zhenyuw@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com [66.147.249.253]) by gabe.freedesktop.org (Postfix) with SMTP id 2FE939E85B for ; Mon, 21 Mar 2011 10:40:54 -0700 (PDT) In-Reply-To: <1300699639-23996-5-git-send-email-zhenyuw@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zhenyu Wang Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 21 Mar 2011 17:27:15 +0800 Zhenyu Wang wrote: > we don't use it anywhere. > > Signed-off-by: Zhenyu Wang > --- > drivers/gpu/drm/i915/i915_suspend.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c > index 7f00f8b..11e61a3 100644 > --- a/drivers/gpu/drm/i915/i915_suspend.c > +++ b/drivers/gpu/drm/i915/i915_suspend.c > @@ -819,9 +819,6 @@ int i915_save_state(struct drm_device *dev) > if (IS_GEN6(dev)) > gen6_disable_rps(dev); > > - /* Cache mode state */ > - dev_priv->saveCACHE_MODE_0 = I915_READ(CACHE_MODE_0); > - > /* Memory Arbitration state */ > dev_priv->saveMI_ARB_STATE = I915_READ(MI_ARB_STATE); > > @@ -867,9 +864,6 @@ int i915_restore_state(struct drm_device *dev) > if (IS_GEN6(dev)) > gen6_enable_rps(dev_priv); > > - /* Cache mode state */ > - I915_WRITE (CACHE_MODE_0, dev_priv->saveCACHE_MODE_0 | 0xffff0000); > - > /* Memory arbitration state */ > I915_WRITE (MI_ARB_STATE, dev_priv->saveMI_ARB_STATE | 0xffff0000); I'd be fine with this if we actually set CACHE_MODE_0 to a reasonable value somewhere else. But right now we rely on the BIOS settings and for the BIOS to reprogram it at resume, which may or may not be reliable. -- Jesse Barnes, Intel Open Source Technology Center