From: Jesse Barnes Subject: Re: [PATCH 8/8] drm/i915: only save/restore VGA clock regs for non-KMS case Date: Mon, 21 Mar 2011 10:49:04 -0700 Message-ID: <20110321104904.261a7ed2@jbarnes-desktop> References: <1300699639-23996-1-git-send-email-zhenyuw@linux.intel.com> <1300699639-23996-9-git-send-email-zhenyuw@linux.intel.com> <849307$c2sdhr@azsmga001.ch.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cpoproxy1-pub.bluehost.com (cpoproxy1-pub.bluehost.com [69.89.21.11]) by gabe.freedesktop.org (Postfix) with SMTP id 74B819E9E0 for ; Mon, 21 Mar 2011 10:49:07 -0700 (PDT) In-Reply-To: <849307$c2sdhr@azsmga001.ch.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 21 Mar 2011 09:49:23 +0000 Chris Wilson wrote: > On Mon, 21 Mar 2011 17:27:19 +0800, Zhenyu Wang wrote: > > For KMS we want to disable VGA anyway, do so by using correct setting > > order in i915_disable_vga(). > > Whilst we are here... Can anybody explain the distinction between those > VGA registers and i915_save_vga()? Might this be a good point to merge > those code blocks and add some comments? And/or just move this block into the modeset_regs function, since it already checks for modesetting. Not sure if the divisor regs are aliases for the CRTC regs or not; the VGA plane control reg is definitely separate though. -- Jesse Barnes, Intel Open Source Technology Center