From: Zhenyu Wang Subject: Re: [PATCH 4/8] drm/i915: remove CACHE_MODE_0 save/restore Date: Tue, 22 Mar 2011 09:20:20 +0800 Message-ID: <20110322012020.GH27541@zhen-devel.sh.intel.com> References: <1300699639-23996-1-git-send-email-zhenyuw@linux.intel.com> <1300699639-23996-5-git-send-email-zhenyuw@linux.intel.com> <20110321104051.78a89723@jbarnes-desktop> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2139108243==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id BEAE99E73D for ; Mon, 21 Mar 2011 18:20:21 -0700 (PDT) In-Reply-To: <20110321104051.78a89723@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2139108243== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GV0iVqYguTV4Q9ER" Content-Disposition: inline --GV0iVqYguTV4Q9ER Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011.03.21 10:40:51 -0700, Jesse Barnes wrote: > On Mon, 21 Mar 2011 17:27:15 +0800 > Zhenyu Wang wrote: >=20 > > we don't use it anywhere. > >=20 > > Signed-off-by: Zhenyu Wang > > --- > > drivers/gpu/drm/i915/i915_suspend.c | 6 ------ > > 1 files changed, 0 insertions(+), 6 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915= /i915_suspend.c > > index 7f00f8b..11e61a3 100644 > > --- a/drivers/gpu/drm/i915/i915_suspend.c > > +++ b/drivers/gpu/drm/i915/i915_suspend.c > > @@ -819,9 +819,6 @@ int i915_save_state(struct drm_device *dev) > > if (IS_GEN6(dev)) > > gen6_disable_rps(dev); > > =20 > > - /* Cache mode state */ > > - dev_priv->saveCACHE_MODE_0 =3D I915_READ(CACHE_MODE_0); > > - > > /* Memory Arbitration state */ > > dev_priv->saveMI_ARB_STATE =3D I915_READ(MI_ARB_STATE); > > =20 > > @@ -867,9 +864,6 @@ int i915_restore_state(struct drm_device *dev) > > if (IS_GEN6(dev)) > > gen6_enable_rps(dev_priv); > > =20 > > - /* Cache mode state */ > > - I915_WRITE (CACHE_MODE_0, dev_priv->saveCACHE_MODE_0 | 0xffff0000); > > - > > /* Memory arbitration state */ > > I915_WRITE (MI_ARB_STATE, dev_priv->saveMI_ARB_STATE | 0xffff0000); >=20 > I'd be fine with this if we actually set CACHE_MODE_0 to a reasonable > value somewhere else. But right now we rely on the BIOS settings and > for the BIOS to reprogram it at resume, which may or may not be > reliable. >=20 I think if we don't touch it in driver we might just keep as it, but your concern seems reasonable as well... I'll test to see if this really impacts on suspend issue. --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --GV0iVqYguTV4Q9ER Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk2H+VQACgkQsQQaM014GCeF1QCfWuX2VofJ2bo10s0RAg6lKAuh N5cAoJVlxyoK/1iWzAjS7LpT3aPhrRLP =g6Fa -----END PGP SIGNATURE----- --GV0iVqYguTV4Q9ER-- --===============2139108243== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2139108243==--