From: Zhenyu Wang Subject: Re: [PATCH 7/8] drm/i915: move sandybridge RC6 enable in resume after ring initialization Date: Tue, 22 Mar 2011 09:48:45 +0800 Message-ID: <20110322014845.GL27541@zhen-devel.sh.intel.com> References: <1300699639-23996-1-git-send-email-zhenyuw@linux.intel.com> <1300699639-23996-8-git-send-email-zhenyuw@linux.intel.com> <20110321104653.4e7afb69@jbarnes-desktop> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1556698474==" Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 6699A9E747 for ; Mon, 21 Mar 2011 18:48:47 -0700 (PDT) In-Reply-To: <20110321104653.4e7afb69@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1556698474== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NqSa+Xr3J/G6Hhls" Content-Disposition: inline --NqSa+Xr3J/G6Hhls Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011.03.21 10:46:53 -0700, Jesse Barnes wrote: > On Mon, 21 Mar 2011 17:27:18 +0800 > Zhenyu Wang wrote: >=20 > > Move RC6 enable after we reset rings for all regines, as RC6 on > > Sandybridge would setup ring idle state, so I assume we should have > > setup rings already. >=20 > So you're seeing the idle value get clobbered? Otherwise it's it > better to set the ring idle value before actually starting the ring? >=20 Don't know, but I can ask if we should do like that or not. I had more stable test result with this. --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --NqSa+Xr3J/G6Hhls Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEUEARECAAYFAk2H//0ACgkQsQQaM014GCegmQCRAUegEApDNmSno+c969gVqoW/ 6QCfc197l4dNQgQGEEYpNhWnM1on9vI= =KE1J -----END PGP SIGNATURE----- --NqSa+Xr3J/G6Hhls-- --===============1556698474== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1556698474==--