From: Konrad Rzeszutek Wilk Subject: Re: [RFC PATCH V4 4/5] cpuidle: driver for xen Date: Thu, 24 Mar 2011 08:05:22 -0400 Message-ID: <20110324120522.GB29294@dumpdata.com> References: <20110322123208.28725.30945.stgit@tringupt.in.ibm.com> <20110322123324.28725.3131.stgit@tringupt.in.ibm.com> <20110322145054.GB26952@dumpdata.com> <4D89C40B.4020809@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Len Brown Cc: venki@google.com, ak@linux.intel.com, suresh.b.siddha@intel.com, sfr@canb.auug.org.au, peterz@infradead.org, benh@kernel.crashing.org, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, arjan@linux.intel.com, Trinabh Gupta List-Id: xen-devel@lists.xenproject.org On Thu, Mar 24, 2011 at 03:18:14AM -0400, Len Brown wrote: > Is a CONFIG_XEN kernel supposed to use just HLT in idle? For right now.. > > xen_arch_setup() does this: > > pm_idle = default_idle; > boot_option_idle_override = IDLE_HALT; > > which has that effect. I guess this makes sense b/c the > CONFIG_XEN kernel is Dom0 and the real C-sates are done > by the hypervisor? Correct. There are some patches that make the C-states be visible in the Linux kernel, but that hasn't been ported over yet. > > Would the same CONFIG_XEN kernel binary ever not > run xen_arch_setup(), run on raw hardware, and want ever not? I am not sure of the question, so let me state: The Linux kernel if compiled with CONFIG_XEN, and if run on native hardware, would _never_ run 'xen_arch_setup()'*. It would run the normal, native type setup. > to use idle states other than HLT? > *: It could if you really really wanted. You would need to change the GRUB2 to inject some extra data in the 'sub_hardware' flag to be the Xen specific.