From: Jesse Barnes Subject: Re: [PATCH] drm/i915: use i915_enable_rc6 on SNB too Date: Wed, 30 Mar 2011 14:45:22 -0700 Message-ID: <20110330144522.33411da1@jbarnes-desktop> References: <20110330140856.1f529ec6@jbarnes-desktop> <20110330213251.GA25609@snipes.kumite> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy2-pub.bluehost.com (oproxy2-pub.bluehost.com [67.222.39.60]) by gabe.freedesktop.org (Postfix) with SMTP id 660539E774 for ; Wed, 30 Mar 2011 15:42:40 -0700 (PDT) In-Reply-To: <20110330213251.GA25609@snipes.kumite> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 30 Mar 2011 14:32:51 -0700 Ben Widawsky wrote: > On Wed, Mar 30, 2011 at 02:08:56PM -0700, Jesse Barnes wrote: > > For debug & testing. > > > > Signed-off-by: Jesse Barnes > > --- > > > I915_WRITE(GEN6_RC_CONTROL, > > - GEN6_RC_CTL_RC6p_ENABLE | > > - GEN6_RC_CTL_RC6_ENABLE | > > + rc6_mask | > > GEN6_RC_CTL_EI_MODE(1) | > > GEN6_RC_CTL_HW_ENABLE); > > > > Do you also need to set GEN6_RC_CTL_RC7_ENABLE if !i915_enable_rc6? I > don't really know how the hardware works, but I had a similar untested > patch except I added that bit in the rc6 disable case. That seems to control LLC way sharing between GT and the CPU; not sure if switching to an RC7 message is correct or not if RC6 is disabled though. -- Jesse Barnes, Intel Open Source Technology Center