From: Ben Widawsky Subject: Re: [PATCH] drm/i915: use i915_enable_rc6 on SNB too Date: Wed, 30 Mar 2011 14:32:51 -0700 Message-ID: <20110330213251.GA25609@snipes.kumite> References: <20110330140856.1f529ec6@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id B542D9E76A for ; Wed, 30 Mar 2011 14:34:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20110330140856.1f529ec6@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 30, 2011 at 02:08:56PM -0700, Jesse Barnes wrote: > For debug & testing. > > Signed-off-by: Jesse Barnes > --- > I915_WRITE(GEN6_RC_CONTROL, > - GEN6_RC_CTL_RC6p_ENABLE | > - GEN6_RC_CTL_RC6_ENABLE | > + rc6_mask | > GEN6_RC_CTL_EI_MODE(1) | > GEN6_RC_CTL_HW_ENABLE); > Do you also need to set GEN6_RC_CTL_RC7_ENABLE if !i915_enable_rc6? I don't really know how the hardware works, but I had a similar untested patch except I added that bit in the rc6 disable case. Otherwise, you can my r-b: Reviewed-by: Ben Widawsky