From: Mike Frysinger Date: Mon, 4 Apr 2011 21:53:15 -0400 Subject: [U-Boot] env: fix env var autocompletion In-Reply-To: <20110404201745.3ffc30cb.kim.phillips@freescale.com> References: <20110404201745.3ffc30cb.kim.phillips@freescale.com> Message-ID: <201104042153.16448.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, April 04, 2011 21:17:45 Kim Phillips wrote: > commit 560d424b6d7cd4205b062ad95f1b104bd4f8bcc3 "env: re-add > support for auto-completion" fell short of its description - > the 'used' logic in hmatch_r was reversed - 'used' is 0 if > the hash table entry is not used, or -1 if deleted. This > patch makes hmatch_r actually match on valid ('used') entries, > instead of skipping them and failing to match anything. i dont think my commit is wrong. i think the bug you describe was actually added in c81c1222427f268d29ba999c82e2477c428e7bab. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110404/ba3e4062/attachment.pgp