From: Mike Frysinger Date: Wed, 13 Apr 2011 15:46:22 -0400 Subject: [U-Boot] [PATCH 0/4] generic mmc_spi driver In-Reply-To: References: <1293174969-18653-1-git-send-email-thomas@wytron.com.tw> <201104120258.15401.vapier@gentoo.org> Message-ID: <201104131546.23464.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, April 13, 2011 06:17:43 Andy Fleming wrote: > On Tue, Apr 12, 2011 at 1:58 AM, Mike Frysinger wrote: > > On Friday, December 24, 2010 02:16:05 Thomas Chou wrote: > >> This is the v9 update of the mmc_spi driver. Please enable DEBUG on the > >> top of mmc_spi.c and help me perform the tests. > >> > >> A new spi_set_speed() is added to meet the 400KHz clock requirement > >> during mmc card initialization. An example update to bfin_spi is > >> included. The altera_spi core does not support speed change, so I am > >> going to post a new opencore ip for this. > >> > >> The driver now claims and releases the spi bus for each mmc command, as > >> Mike suggested. > >> > >> Thomas Chou (4): > >> lib: add crc7 from Linux > >> spi: add spi_set_speed func > >> bfin_spi: add spi_set_speed > >> mmc: add generic mmc spi driver > > > > Andy: i think we've hit a fairly stable point. could you merge this now > > ? > > I'm going to merge this, but I'll note that the reason you had to run > mmcinfo before this will work is because this code never invoks > mmc_init(). If you look at the mmc command in common/cmd_mmc.c, and > see how the various sub-commands operate (under GENERIC_MMC), all of > them call mmc_init() before running the command. It's suboptimal in > terms of performance, but has the advantage of being robust and > actually detecting if you put a card in, or took one out. If someone > could find the appropriate places to call mmc_init(mmc), I'll be happy > to also merge in the follow-up patch. i hope Thomas can do that :) > Also, I'm assuming, at the moment, that this supersedes the legacy > mmc_spi patch you submitted earlier? If not, I'll put that in, now, > too. correct, the legacy mmc_spi code is hopefully no longer needed -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110413/ea65099d/attachment.pgp