From: Mike Frysinger Date: Fri, 15 Apr 2011 03:57:29 -0400 Subject: [U-Boot] [PATCH v2] lib/hashtable: fix env var autocompletion In-Reply-To: <20110405121450.099cb324.kim.phillips@freescale.com> References: <20110404201745.3ffc30cb.kim.phillips@freescale.com> <4D9A9E41.9000901@logicpd.com> <20110405121450.099cb324.kim.phillips@freescale.com> Message-ID: <201104150357.30604.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, April 05, 2011 13:14:50 Kim Phillips wrote: > commit c81c1222427f268d29ba999c82e2477c428e7bab "Fix hash > table deletion to prevent lost entries" broke environment > variable autocompletion by accidentally inverting the > condition for 'used' in hmatch_r(). > > 'used' is 0 if the hash table entry is not used, or -1 if deleted. > This patch makes hmatch_r actually match on valid ('used') entries, > instead of skipping them and failing to match anything. blah, this started to annoy me quite a bit. and your patch wfm. Tested-by: Mike Frysinger -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110415/67e4ec72/attachment.pgp