From: Christoph Hellwig Subject: Re: [PATCH 3/3] writeback: avoid extra sync work at enqueue time Date: Thu, 5 May 2011 14:41:22 +0200 Message-ID: <20110505124122.GA24009@lst.de> References: <20110502031750.135798606@intel.com> <20110502033035.789279347@intel.com> <20110504212427.GI6968@quack.suse.cz> <20110505122732.GC1294@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Andrew Morton , Dave Chinner , Christoph Hellwig , LKML , "linux-fsdevel@vger.kernel.org" To: Wu Fengguang Return-path: Content-Disposition: inline In-Reply-To: <20110505122732.GC1294@localhost> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, May 05, 2011 at 08:27:32PM +0800, Wu Fengguang wrote: > - wbc.wb_start = jiffies; /* livelock avoidance */ > + oldest_jif = jiffies; > + wbc.older_than_this = &oldest_jif; Can't you kill the oldest_jif variable now?