From: Jesse Barnes Subject: Re: [PATCH] drm/i915: initialize ring frequency scaling table on SNB Date: Thu, 23 Jun 2011 13:16:59 -0700 Message-ID: <20110623131659.07465ad8@jbarnes-desktop> References: <20110621152424.75f54a13@jbarnes-desktop> <8762nxiu83.fsf@eliezer.anholt.net> <20110622125646.37597e13@jbarnes-vaio.home> <20110623101126.58cba07c@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy7-pub.bluehost.com (oproxy7-pub.bluehost.com [67.222.55.9]) by gabe.freedesktop.org (Postfix) with SMTP id 112829E8B8 for ; Thu, 23 Jun 2011 13:17:08 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 23 Jun 2011 21:08:02 +0100 Chris Wilson wrote: > On Thu, 23 Jun 2011 10:11:26 -0700, Jesse Barnes wrote: > > I tested again and things were working as expected. This patch adds a > > debugfs file for dumping the ring freq table, can you guys test it out > > (try disabling the call to update the table, dump it, make sure it's 0, > > then re-enable and make sure it's programmed correctly). > > According to the debugfs, your defaults should be effective: > > sandybridge:~$ cat /sys/kernel/debug/dri/1/i915_ring_freq_table > GPU freq Effective CPU freq > 850 0 -> 1600 > 900 0 -> 1700 > 950 0 -> 1800 > 1000 0 -> 1800 > 1050 0 -> 1900 > 1100 0 -> 2000 > > I'll give the tyres another kick and see if I can spot any differences. Eric was seeing an increase, but not as large as expected or hoped for. He saw a greater increase in performance than this patch provides by simply keeping the CPU busy during his benchmark. That could be due to additional ring frequency when the CPU is in a turbo mode. You may be able to approach that by making the effective CPU frequency much higher (maybe going up to 4GHz). -- Jesse Barnes, Intel Open Source Technology Center