From: Konrad Rzeszutek Wilk Subject: Re: xen-blkfront: Don't send closing notification to backend in blkfront_closing() Date: Tue, 12 Jul 2011 11:04:09 -0400 Message-ID: <20110712150409.GB7831@dumpdata.com> References: <4E16AE55.50500@oracle.com> <20110708160414.GA30120@dumpdata.com> <4E17A01F.8060505@oracle.com> <20110709131153.GA25916@dumpdata.com> <4E1BBFFD.7030900@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4E1BBFFD.7030900@oracle.com> Sender: linux-kernel-owner@vger.kernel.org To: Joe Jin Cc: Daniel Stodden , Jens Axboe , annie.li@oracle.com, Jeremy Fitzhardinge , Ian Campbell , Kurt C Hackel , Greg Marsden , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" List-Id: xen-devel@lists.xenproject.org > without the patch, after detach the device by xm block-detach timeout also umount hang in guest. > with my patch, xm block-detach timeout in Dom0, umount in guest worked! Ah, I failed to spot you did the unmount after the timeout. I tried to do the umount after forcing the block-detach. [and testing confirms your patch working properly] Looks good to me - with the only exception that the description needs to have 'xm block-attach' and 'xm block-detach' - please change that and resubmit and attach Reviewed-by: Konrad Rzeszutek Wilk CC: stable@kernel.org and make sure to have Jens in the 'To:' header. Thanks! Jens, Are you OK picking the amended patch (shortly to be posted) for 3.0-rc7?