From: Jesse Barnes Subject: Re: [PATCH] drm/i915: Set crtc DPMS mode to ON in intel_crtc_mode_set Date: Wed, 27 Jul 2011 10:23:50 -0700 Message-ID: <20110727102350.71fddc09@jbarnes-desktop> References: <1311755616-3379-1-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy3-pub.bluehost.com (oproxy3-pub.bluehost.com [69.89.21.8]) by gabe.freedesktop.org (Postfix) with SMTP id 091799E7A1 for ; Wed, 27 Jul 2011 10:23:58 -0700 (PDT) In-Reply-To: <1311755616-3379-1-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 27 Jul 2011 01:33:36 -0700 Keith Packard wrote: > This corrects the DPMS mode tracking so that the DPMS code will > actually turn the CRTC off the next time the screen saves. > > Signed-off-by: Keith Packard > --- > drivers/gpu/drm/i915/intel_display.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index fc26cb4..d9b8c15 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -5273,6 +5273,8 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc, > > drm_vblank_post_modeset(dev, pipe); > > + intel_crtc->dpms_mode = DRM_MODE_DPMS_ON; > + > return ret; > } Aside from a general objection about our seeming inability to track DPMS state properly: Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center