From: Olaf Hering Subject: Re: [Xen-devel] [PATCH 2/3] xen/pv-on-hvm kexec: rebind virqs to existing eventchannel ports Date: Tue, 9 Aug 2011 17:28:06 +0200 Message-ID: <20110809152806.GA12710@aepfle.de> References: <20110804162053.723541930@aepfle.de> <20110804162054.510901329@aepfle.de> <1312881460.26263.46.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1312881460.26263.46.camel@zakaz.uk.xensource.com> Sender: linux-kernel-owner@vger.kernel.org To: Ian Campbell Cc: "linux-kernel@vger.kernel.org" , Jeremy Fitzhardinge , Konrad , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Tue, Aug 09, Ian Campbell wrote: > On Thu, 2011-08-04 at 17:20 +0100, Olaf Hering wrote: > > During a kexec boot some virqs such as timer and debugirq were already > > registered by the old kernel. The hypervisor will return -EEXISTS from > > the new EVTCHNOP_bind_virq request and the BUG in bind_virq_to_irq() > > triggers. Catch the -EEXISTS error and loop through all possible ports to find > > what port belongs to the virq/cpu combo. > > Would it be better to proactively just query the status of all event > channels early on, like you do in find_virq, and setup the irq info > structures as appropriate? Rather than waiting for an -EEXISTS I mean. Now that I read that again more carefully: No idea if thats possible, I will leave that answer to Jeremy/Konrad. Olaf