From: Matthew Garrett Subject: Re: [PATCH] i915: do not setup intel_backlight twice Date: Mon, 22 Aug 2011 20:42:04 +0100 Message-ID: <20110822194204.GA6361@srcf.ucam.org> References: <20110817141010.GA21479@redhat.com> <1314041950-12433-1-git-send-email-kamal@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1314041950-12433-1-git-send-email-kamal@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Kamal Mostafa Cc: Linux Kernel , intel-gfx@lists.freedesktop.org, Keith Packard List-Id: intel-gfx@lists.freedesktop.org On Mon, Aug 22, 2011 at 12:39:10PM -0700, Kamal Mostafa wrote: > The commit "Not all systems expose a firmware or platform mechanism for > changing the backlight intensity on i915, so add native driver support" > adds calls to intel_panel_setup_backlight() from intel_{lvds,dp}_init > so do not call it again from intel_setup_outputs(). > > BugLink: http://bugs.launchpad.net/bugs/831542 > > Signed-off-by: Kamal Mostafa ACKed-by: Matthew Garrett -- Matthew Garrett | mjg59@srcf.ucam.org