From: Ben Widawsky Subject: Re: [PATCH] drm/i915: Dumb down the semaphore logic Date: Sat, 3 Sep 2011 13:09:47 -0700 Message-ID: <20110903130947.6b43a474@bwidawsk.net> References: <1314935735-5451-1-git-send-email-ben@bwidawsk.net> <87fwkeahgb.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id A36189F03B for ; Sat, 3 Sep 2011 13:10:09 -0700 (PDT) In-Reply-To: <87fwkeahgb.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt , Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 02 Sep 2011 12:10:28 -0700 Eric Anholt wrote: > On Thu, 1 Sep 2011 20:55:35 -0700, Ben Widawsky > wrote: > > While I think the previous code is correct, it was hard to follow > > and hard to debug. Since we already have a ring abstraction, might > > as well use it to handle the semaphore updates and compares. > > > > I don't expect this code to make semaphores better or worse, but you > > never know... > > This code is generally more legible, and I think I could review it > compared to the specs in a few minutes instead of the awful I > experience I had reviewing what was there before (particularly the > awful % tricks). Still, some review inline: Keith, worth cleaning this one up?