From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] xen: Fix selfballooning and ensure it doesn't go too far Date: Mon, 26 Sep 2011 13:23:07 -0400 Message-ID: <20110926172307.GA9973@phenom.oracle.com> References: <9827a70d-dfb2-4bbc-9df6-207b10c835ac@default> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <9827a70d-dfb2-4bbc-9df6-207b10c835ac@default> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer Cc: Jeremy Fitzhardinge , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, David Vrabel List-Id: xen-devel@lists.xenproject.org On Sat, Sep 24, 2011 at 01:58:08PM -0700, Dan Magenheimer wrote: > [PATCH] xen: Fix selfballooning and ensure it doesn't go too far > > The balloon driver's "current_pages" is very different from > totalram_pages. Self-ballooning needs to be driven by > the latter. Also, Committed_AS doesn't account for pages > used by the kernel so enforce a floor for when there > are little or no user-space threads using memory. Hey Dan, .. > + floor_pages = totalreserve_pages + > + (roundup_pow_of_two(max_pfn) >> 5); Would it make sense to make the shift be a runtime argument in case some users report problems with that calculation? > + /* don't balloon too far, lest OOMs occur... */ > + if (tgt_pages < floor_pages) > + tgt_pages = floor_pages; > + balloon_set_new_target(tgt_pages + > + balloon_stats.current_pages - totalram_pages); > reset_timer = true; > } > #ifdef CONFIG_FRONTSWAP Otherwise it looks OK to me. Would you like me to queue it up for 3.1-rc7?