From: Ben Widawsky Subject: Re: [PATCH] drm/i915: blitter ring workaround for gen6 Date: Mon, 3 Oct 2011 00:59:45 -0700 Message-ID: <20111003005945.39835a47@bwidawsk.net> References: <1317605232-4569-1-git-send-email-ben@bwidawsk.net> <20111003074128.GB2812@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D1B39E7D0 for ; Mon, 3 Oct 2011 00:59:40 -0700 (PDT) In-Reply-To: <20111003074128.GB2812@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 3 Oct 2011 09:41:28 +0200 Daniel Vetter wrote: > On Sun, Oct 02, 2011 at 06:27:12PM -0700, Ben Widawsky wrote: > > Found this through doc inspection. I don't have a failing test case that this > > fixes, but the docs specify we need to do it in addition to the A0 workaround. > > Can you confirm that the A0 workaround is really needed in addition to > this new work-around on production-hw? Because I have patches lying around > to kill that mess (no need don't carry around workarounds that only apply > to pre-production hw after hw bringup) and your patch seems to extend that > A0 workaround to all chips. > -Daniel It appears it is needed assuming I can make the patch do something useful. The docs are so terribly vague about what this actually fixes, or how it should be implemented. By the way, it's not all chips, again once I get this to do something useful, I'll clean things up. Ben