From: Jesse Barnes Subject: Re: [PATCH 1/4] drm/i915: PLL macro cleanup and pipe assertion check Date: Wed, 5 Oct 2011 11:25:44 -0700 Message-ID: <20111005112544.052a516e@jbarnes-desktop> References: <1317835521-10183-1-git-send-email-jbarnes@virtuousgeek.org> <1317835521-10183-2-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0535683527==" Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id 165E69E78B for ; Wed, 5 Oct 2011 11:25:53 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0535683527== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/kyFdRHsrrBjMnMHIqn3qoiG"; protocol="application/pgp-signature" --Sig_/kyFdRHsrrBjMnMHIqn3qoiG Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 05 Oct 2011 11:07:53 -0700 Keith Packard wrote: > On Wed, 5 Oct 2011 10:25:18 -0700, Jesse Barnes wrote: >=20 > > Add a macro for accessing the two pipe PLLs and add a check to make sure > > we don't access a non-existent one in the enable/disable functions. >=20 > So, I haven't read through the specs, but are the PLLs tied to specific > pipes? Or are we really talking about a different object here, and just > mis-naming it as a 'pipe'? They're not hardwired; we can use the DPLL_SEL reg to control which PLL drives which transcoder. Unfortunately our old pipe terminology is a bit outdated with the PCH split. It used to be the pipe was fairly self-contained: a PLL with pipe and plane controls. Now it's split across the CPU and PCH with FDI in between (sometimes) and transcoder configuration (sometimes with DP). --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/kyFdRHsrrBjMnMHIqn3qoiG Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOjKEoAAoJEIEoDkX4Qk9hz3wQAJo41162Tpsr8I8VJFxMmnF1 GSmx0uklO47VOVFEoc3Qf/VTHFzkck9ZrF8JvRKxqfZIJy15mo5mEGobhYh1MKRO tb0ngUr+XKIN+xLkKVRNcsESxEGIselpqcdi+LJYj6Lgzs+qKJSvLYt0hczkUVAG D4AR2p+d8UBOWMBXmujdVP3CVM3wnnU+465u7aPAlWY2g9uZaD4M7yfCCMFzSi7T lvPWgOTpLrUmAbmSOpdcOqjx836piLlZyrf5tt+F2YTOPx7+VDRn/kictcllInW3 izQ8bA6gtSlEWXZkHlSO/WDyMyV2eBg7f+JAhk1I3IesNQ9EykBETc5Rd1yCfx0D tsuuSmtr5Plyr0G4pru9buJ8rcjChxDqZLlOY2oRAjZHfYdAMKKyNQlaaJ5Mkmwx cRtzSj7CpVX6yB53AgNp9geDpiFocPNI26GgrnxGgF8cXa4+4b3SumwMmAqy/rZL MBodSZSjLlF6dfZTCXdSTT99SxP4hhYUnbrha9ADCbhPcRKkopr35R0D3TaWesAw BB5Sa9iV4lJxIvr5VV1ZtOsDKBmTCvaQeq5VnSHnSC/kS62+cOL0pP74hK4E60b9 uPso5YfzipMWrX1Wo3U4l9qNSJkPUGaPjoo5k8VcE4VVp8MNjRl2LoEPb2+r1z82 6iIicKrLXc1xFCLlYLnG =k/58 -----END PGP SIGNATURE----- --Sig_/kyFdRHsrrBjMnMHIqn3qoiG-- --===============0535683527== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0535683527==--