From: Ben Widawsky Subject: Re: [PATCH] drm/i915: Remove secure batch buffer flag SNB+ Date: Wed, 5 Oct 2011 15:05:57 -0700 Message-ID: <20111005150557.23fba57b@bwidawsk.net> References: <1317844916-5107-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 519F39ECBD for ; Wed, 5 Oct 2011 15:06:11 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 05 Oct 2011 22:26:54 +0100 Chris Wilson wrote: > On Wed, 5 Oct 2011 13:01:56 -0700, Ben Widawsky wrote: > > Docs say that the secure batchbuffer field for > SNB B0 (products that > > actually shipped) should be 0 when not using PPGTT. I'd guess this has > > no positive or negative effect, but is just here to jive with the docs. > > How explicit is the warning? Enough to allow arbitrary writes into the > MMIO space? > -Chris > The docs really suck, and I am honestly quite confused. It simply says (for both blitter and render): "This field must be '0' unless the Per-Process GTT Enable is '1'" :/ I'm sure we already have a test for it, but I can write one if not. Ben