From: Dan Carpenter Date: Thu, 06 Oct 2011 06:17:00 +0000 Subject: [patch] Staging: iio/adc/ad7150: release lock on error Message-Id: <20111006061700.GC14701@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jonathan Cameron Cc: Greg Kroah-Hartman , Michael Hennerich , Paul Gortmaker , Mike Frysinger , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org The error_ret label should have been before the mutex_unlock(). It's a typo. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/iio/adc/ad7150.c b/drivers/staging/iio/adc/ad7150.c index 8943420..d1767d8 100644 --- a/drivers/staging/iio/adc/ad7150.c +++ b/drivers/staging/iio/adc/ad7150.c @@ -332,8 +332,8 @@ static int ad7150_write_event_value(struct iio_dev *indio_dev, /* write back if active */ ret = ad7150_write_event_params(indio_dev, event_code); - mutex_unlock(&chip->state_lock); error_ret: + mutex_unlock(&chip->state_lock); return ret; }