From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Remove secure batch buffer flag SNB+ Date: Thu, 6 Oct 2011 13:13:10 +0200 Message-ID: <20111006111310.GB2851@phenom.ffwll.local> References: <1317844916-5107-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 671109E8CF for ; Thu, 6 Oct 2011 04:12:34 -0700 (PDT) Received: by wyi11 with SMTP id 11so3433802wyi.36 for ; Thu, 06 Oct 2011 04:12:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 05, 2011 at 10:26:54PM +0100, Chris Wilson wrote: > On Wed, 5 Oct 2011 13:01:56 -0700, Ben Widawsky wrote: > > Docs say that the secure batchbuffer field for > SNB B0 (products that > > actually shipped) should be 0 when not using PPGTT. I'd guess this has > > no positive or negative effect, but is just here to jive with the docs. > > How explicit is the warning? Enough to allow arbitrary writes into the > MMIO space? I've run this on my snb the past month and couldn't find anything this unbreaks. Afaics it allows batchbuffers to run a few more MI commands instead of hanging the gpu with them. But we're not using these from userspace and they only started to be allowed on snb+ - previous gens convert them to noops. Also this allows arbitrary reads/writes to system memory, because with this batchbuffers can update gtt ptes with MI_UPDATE_GTT. Even when we find an actual hang this fixes, I think implement ppgtt is the right thing to do. So NAKed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48