From: Jesse Barnes Subject: Re: [PATCH 3/5] drm/i915/pch: Fix thinko in DPLL disable Date: Wed, 12 Oct 2011 15:17:53 -0700 Message-ID: <20111012151753.1a13c33d@jbarnes-desktop> References: <1318012726-30158-1-git-send-email-ajax@redhat.com> <1318012726-30158-4-git-send-email-ajax@redhat.com> <20111012150311.48748669@jbarnes-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0684209631==" Return-path: Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id 717809E841 for ; Wed, 12 Oct 2011 15:18:05 -0700 (PDT) In-Reply-To: <20111012150311.48748669@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0684209631== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/r3puxT+U3rbbaCMEORRzOGZ"; protocol="application/pgp-signature" --Sig_/r3puxT+U3rbbaCMEORRzOGZ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 12 Oct 2011 15:03:11 -0700 Jesse Barnes wrote: > On Fri, 7 Oct 2011 14:38:44 -0400 > Adam Jackson wrote: >=20 > > For transcoder A, we would never clear the DPLL[AB] select bit. If the > > firmware had set us up on DPLLB, the effect would be to attempt to use > > DPLLB for both pipes A and B, which would probably be bad. > >=20 > > Signed-off-by: Adam Jackson > > --- > > drivers/gpu/drm/i915/intel_display.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i91= 5/intel_display.c > > index 9edf363..67dbe22 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -3051,7 +3051,7 @@ static void ironlake_crtc_disable(struct drm_crtc= *crtc) > > temp =3D I915_READ(PCH_DPLL_SEL); > > switch (pipe) { > > case 0: > > - temp &=3D ~(TRANSA_DPLL_ENABLE | TRANSA_DPLLA_SEL); > > + temp &=3D ~(TRANSA_DPLL_ENABLE | TRANSA_DPLLB_SEL); > > break; > > case 1: > > temp &=3D ~(TRANSB_DPLL_ENABLE | TRANSB_DPLLB_SEL); >=20 > I think this might be even better (goes with the 3 pipe patches)? Ok not really better; we should still mask out the select bits just in case the bios did something screwy. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/r3puxT+U3rbbaCMEORRzOGZ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOlhIRAAoJEIEoDkX4Qk9h2RQP/0XcjR2n9jKF6R8QRag6HaAY D4OINDaFugQlux3v95rki4WoVXJyqDXbCh+q8ZvQ3cJeD+tjVu9VEnPTMl/pTPTm y/mE6hnnG5XhCnWrLr8POVG3kWUxVzeGnX3tjWsswShlj2Zaa/dxjz9igT2ANZby 0XC+9d76EnAQv/SlgKQvoQWofs2KxHSqUs9OekPsi9RlJspZf2wJLsnB3bC7tSrL BREOOCwjKpPnMU01KtjsWNGHEW8MiWi6Goz8nXVUZRG1bpmbEfm4X/9oDu4FqSSb spPLF42XuoJ9FndNLs5KpKbi+XpJ6CMNrZgkjIYm9OHblbqK/08CVbm1OXLrEbTk wgGRerIALK93/1C+lFytlOpWAKCxM1bTRhNp846Ou4ynzY1XR9Ns7f1ayuSsHbWp Sw9CuNlQUB9dS8pyTRcd1cuCE6FcgejUO/+tJttWmAf3pFsA/AfzCTsY7zg2TfGQ 47mdF+rn9vbfE7Grf8xfh4ZP/llPABHSd7feA1WR52Web6MXnOezCk+hx2CgSuWc ccgpiVHwnA+XGPyT6wV+kFMzYXfGiEDAFNHMg8V5oGb6g1N3tlyM1J9Lfz7crvyr knE/9V28JRYZV/FC1zVzDUrBadHP+ndy344bgPUb823+xUjgZwWdePx7aBsFExGE DEYzxD4Q45Ok7l+vVGI5 =WqUN -----END PGP SIGNATURE----- --Sig_/r3puxT+U3rbbaCMEORRzOGZ-- --===============0684209631== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0684209631==--